Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/core/events/PointerEvent.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/PointerEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEvent.cpp b/third_party/WebKit/Source/core/events/PointerEvent.cpp
index f3971cc1464937f7a081c6d96b4babcb1784f5f4..fd601a3f734254b20b1d29e98a06655234193c96 100644
--- a/third_party/WebKit/Source/core/events/PointerEvent.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEvent.cpp
@@ -83,21 +83,20 @@ PointerEvent& PointerEventDispatchMediator::event() const
return toPointerEvent(EventDispatchMediator::event());
}
-bool PointerEventDispatchMediator::dispatchEvent(EventDispatcher& dispatcher) const
+DispatchEventResult PointerEventDispatchMediator::dispatchEvent(EventDispatcher& dispatcher) const
{
if (isDisabledFormControl(&dispatcher.node()))
- return false;
+ return DispatchEventResult::CanceledBeforeDispatch;
if (event().type().isEmpty())
- return true; // Shouldn't happen.
+ return DispatchEventResult::NotCanceled; // Shouldn't happen.
ASSERT(!event().target() || event().target() != event().relatedTarget());
EventTarget* relatedTarget = event().relatedTarget();
event().eventPath().adjustForRelatedTarget(dispatcher.node(), relatedTarget);
- dispatcher.dispatch();
- return !event().defaultHandled() && !event().defaultPrevented();
+ return dispatcher.dispatch();
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/events/PointerEvent.h ('k') | third_party/WebKit/Source/core/events/TouchEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698