third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h ('k') | third_party/WebKit/Source/modules/indexeddb/IDBRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp

index 6cfdb3bcd0d06e941c4bb7a1c156c7969ebd290e..1c5ac5bbb60e8f8da5987bbb66f330d879e6e8fa 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp

@@ -162,7 +162,7 @@ bool IDBOpenDBRequest::shouldEnqueueEvent() const

return true;

}

-bool IDBOpenDBRequest::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

+DispatchEventResult IDBOpenDBRequest::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

{

// If the connection closed between onUpgradeNeeded and the delivery of the "success" event,

// an "error" event should be fired instead.

@@ -170,7 +170,7 @@ bool IDBOpenDBRequest::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event

dequeueEvent(event.get());

setResult(nullptr);

onError(DOMException::create(AbortError, "The connection was closed."));

- return false;

+ return DispatchEventResult::CanceledBeforeDispatch;

}

return IDBRequest::dispatchEventInternal(event);