third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/PointerEventManager.cpp ('K') | « third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp b/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

index e1cc325f45a896bd8abce63c84d6cf9affdc0bfe..88262955b222a01eb94ec054ccb79102cb212963 100644

--- a/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

@@ -27,8 +27,9 @@ void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne

// dispatchEvent() returns whether the default behavior can happen. In other

// words, it returns false if preventDefault() was called.

- *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client))

- ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel;

+ *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client)) == DispatchEventResult::NotCanceled

+ ? WebAppBannerPromptReply::None

+ : WebAppBannerPromptReply::Cancel;

}

} // namespace blink