third_party/WebKit/Source/core/html/track/TextTrackCue.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrackCue.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp ('K') | « third_party/WebKit/Source/core/html/track/TextTrackCue.h ('k') | third_party/WebKit/Source/core/input/EventHandler.h » ('j') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/TextTrackCue.cpp

diff --git a/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp b/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp

index d1dd77dbb8d97bb21e859240f025dc3a59b4a380..b906a762ba5dd61c165e45cec64b66f5b1bc571a 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp

+++ b/third_party/WebKit/Source/core/html/track/TextTrackCue.cpp

@@ -136,11 +136,11 @@ unsigned TextTrackCue::cueIndex()

return m_cueIndex;

}

-bool TextTrackCue::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

+DispatchEventResult TextTrackCue::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event)

{

// When a TextTrack's mode is disabled: no cues are active, no events fired.

if (!track() || track()->mode() == TextTrack::disabledKeyword())

- return false;

+ return DispatchEventResult::CanceledBeforeDispatch;

return EventTarget::dispatchEventInternal(event);

}