third_party/WebKit/Source/core/html/HTMLFormElement.cpp - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp ('k') | third_party/WebKit/Source/core/html/track/TextTrackCue.h » ('j') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

index b5453f1ed22fde0da3b15c299ee2c8ace998e3a4..6519101a9743c6e73b791bb93a824e24b3032c94 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp

@@ -326,7 +326,7 @@ void HTMLFormElement::prepareForSubmission(Event* event)

frame->loader().client()->dispatchWillSendSubmitEvent(this);

- if (dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit)))

+ if (dispatchEvent(Event::createCancelableBubble(EventTypeNames::submit)) == DispatchEventResult::NotCanceled)

m_shouldSubmit = true;

m_isSubmittingOrInUserJSSubmitEvent = false;

@@ -447,7 +447,7 @@ void HTMLFormElement::reset()

m_isInResetFunction = true;

- if (!dispatchEvent(Event::createCancelableBubble(EventTypeNames::reset))) {

+ if (dispatchEvent(Event::createCancelableBubble(EventTypeNames::reset)) != DispatchEventResult::NotCanceled) {

m_isInResetFunction = false;

return;

}