third_party/WebKit/Source/core/events/EventDispatchMediator.h - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventDispatchMediator.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/Event.h ('K') | « third_party/WebKit/Source/core/events/Event.h ('k') | third_party/WebKit/Source/core/events/EventDispatchMediator.cpp » ('j') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventDispatchMediator.h

diff --git a/third_party/WebKit/Source/core/events/EventDispatchMediator.h b/third_party/WebKit/Source/core/events/EventDispatchMediator.h

index a0589856bfe9b698e85af57a446f2f0a3c7afe83..b5fe54aed9976d314fd4dfa8da6298e9abde9eed 100644

--- a/third_party/WebKit/Source/core/events/EventDispatchMediator.h

+++ b/third_party/WebKit/Source/core/events/EventDispatchMediator.h

@@ -31,6 +31,7 @@

#ifndef EventDispatchMediator_h

#define EventDispatchMediator_h

+#include "core/events/EventTarget.h"

#include "platform/heap/Handle.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefCounted.h"

@@ -46,7 +47,7 @@ public:

static PassRefPtrWillBeRawPtr<EventDispatchMediator> create(PassRefPtrWillBeRawPtr<Event>);

virtual ~EventDispatchMediator() { }

DECLARE_VIRTUAL_TRACE();

- virtual bool dispatchEvent(EventDispatcher&) const;

+ virtual DispatchEventResult dispatchEvent(EventDispatcher&) const;

Event& event() const { return *m_event; }

protected: