third_party/WebKit/Source/core/editing/SelectionEditor.h - Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add

Patch Set: Fix comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/core/editing/SelectionController.cpp ('k') | third_party/WebKit/Source/core/editing/SelectionEditor.cpp » ('j') | third_party/WebKit/Source/core/events/Event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/SelectionEditor.h

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.h b/third_party/WebKit/Source/core/editing/SelectionEditor.h

index bf3f70a1de81a1445f39aa70973ad511014bfeb4..661fd43466963711de7f4b6766cd442b47f218bc 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.h

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.h

@@ -27,6 +27,7 @@

#define SelectionEditor_h

#include "core/editing/FrameSelection.h"

+#include "core/events/EventTarget.h"

philipj_slow 2016/02/25 15:23:46 Put DispatchEventResult in its own header to other

dtapuska 2016/02/25 22:06:09 Done.

namespace blink {

@@ -111,7 +112,7 @@ private:

void stopObservingVisibleSelectionChangeIfNecessary();

LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);

- bool dispatchSelectStart();

+ DispatchEventResult dispatchSelectStart();

RawPtrWillBeMember<FrameSelection> m_frameSelection;