Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Rename enum values Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.h
diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h
index 0674625268707e3dcfe469af9634a3b4d7956b3e..020233322a54bcd5d1f52c2765a95630f8356741 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.h
+++ b/third_party/WebKit/Source/core/input/EventHandler.h
@@ -179,7 +179,13 @@ public:
void setMouseDownMayStartAutoscroll() { m_mouseDownMayStartAutoscroll = true; }
static WebInputEventResult mergeEventResult(WebInputEventResult resultA, WebInputEventResult resultB);
- static WebInputEventResult eventToEventResult(PassRefPtrWillBeRawPtr<Event>, bool);
+ static WebInputEventResult toWebInputEventResult(DispatchEventResult);
+
+ // Convert |result| into a WebInputEventResult apply asserts for
+ // cases that should not happen in the specified DOM dispatch event model.
+ // Specifically assert failure on DispatchEventResult::CanceledDefaultEventHandler
+ // and DispatchEventResult::CanceledBeforeDispatch.
+ static WebInputEventResult toWebInputEventResultWithStrictAsserts(DispatchEventResult);
static PlatformEvent::Modifiers accessKeyModifiers();
bool handleAccessKey(const PlatformKeyboardEvent&);

Powered by Google App Engine
This is Rietveld 408576698