Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
index c8ff295443d7273f1f30022faea88c0566007c7a..2f23b207c682016008e13a048cc6dcc3f97dc53b 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
@@ -146,13 +146,13 @@ void RespondWithObserver::contextDestroyed()
m_state = Done;
}
-void RespondWithObserver::didDispatchEvent(bool defaultPrevented)
+void RespondWithObserver::didDispatchEvent(WebInputEventResult dispatchResult)
{
ASSERT(executionContext());
if (m_state != Initial)
return;
- if (defaultPrevented) {
+ if (dispatchResult != WebInputEventResult::NotHandled) {
responseWasRejected(WebServiceWorkerResponseErrorDefaultPrevented);
return;
}

Powered by Google App Engine
This is Rietveld 408576698