Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 DEFINE_ATTRIBUTE_EVENT_LISTENER(install); 84 DEFINE_ATTRIBUTE_EVENT_LISTENER(install);
85 DEFINE_ATTRIBUTE_EVENT_LISTENER(activate); 85 DEFINE_ATTRIBUTE_EVENT_LISTENER(activate);
86 DEFINE_ATTRIBUTE_EVENT_LISTENER(fetch); 86 DEFINE_ATTRIBUTE_EVENT_LISTENER(fetch);
87 DEFINE_ATTRIBUTE_EVENT_LISTENER(message); 87 DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
88 DEFINE_ATTRIBUTE_EVENT_LISTENER(foreignfetch); 88 DEFINE_ATTRIBUTE_EVENT_LISTENER(foreignfetch);
89 89
90 DECLARE_VIRTUAL_TRACE(); 90 DECLARE_VIRTUAL_TRACE();
91 91
92 protected: 92 protected:
93 // EventTarget 93 // EventTarget
94 bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override; 94 DispatchEventResult dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) ove rride;
95 bool addEventListenerInternal(const AtomicString& eventType, PassRefPtrWillB eRawPtr<EventListener>, const EventListenerOptions&) override; 95 bool addEventListenerInternal(const AtomicString& eventType, PassRefPtrWillB eRawPtr<EventListener>, const EventListenerOptions&) override;
96 96
97 private: 97 private:
98 ServiceWorkerGlobalScope(const KURL&, const String& userAgent, ServiceWorker Thread*, double timeOrigin, PassOwnPtr<SecurityOrigin::PrivilegeData>, PassOwnPt rWillBeRawPtr<WorkerClients>); 98 ServiceWorkerGlobalScope(const KURL&, const String& userAgent, ServiceWorker Thread*, double timeOrigin, PassOwnPtr<SecurityOrigin::PrivilegeData>, PassOwnPt rWillBeRawPtr<WorkerClients>);
99 void importScripts(const Vector<String>& urls, ExceptionState&) override; 99 void importScripts(const Vector<String>& urls, ExceptionState&) override;
100 PassOwnPtrWillBeRawPtr<CachedMetadataHandler> createWorkerScriptCachedMetada taHandler(const KURL& scriptURL, const Vector<char>* metaData) override; 100 PassOwnPtrWillBeRawPtr<CachedMetadataHandler> createWorkerScriptCachedMetada taHandler(const KURL& scriptURL, const Vector<char>* metaData) override;
101 void logExceptionToConsole(const String& errorMessage, int scriptId, const S tring& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) override; 101 void logExceptionToConsole(const String& errorMessage, int scriptId, const S tring& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) override;
102 void scriptLoaded(size_t scriptSize, size_t cachedMetadataSize) override; 102 void scriptLoaded(size_t scriptSize, size_t cachedMetadataSize) override;
103 103
104 PersistentWillBeMember<ServiceWorkerClients> m_clients; 104 PersistentWillBeMember<ServiceWorkerClients> m_clients;
105 PersistentWillBeMember<ServiceWorkerRegistration> m_registration; 105 PersistentWillBeMember<ServiceWorkerRegistration> m_registration;
106 bool m_didEvaluateScript; 106 bool m_didEvaluateScript;
107 bool m_hadErrorInTopLevelEventHandler; 107 bool m_hadErrorInTopLevelEventHandler;
108 unsigned m_eventNestingLevel; 108 unsigned m_eventNestingLevel;
109 size_t m_scriptCount; 109 size_t m_scriptCount;
110 size_t m_scriptTotalSize; 110 size_t m_scriptTotalSize;
111 size_t m_scriptCachedMetadataTotalSize; 111 size_t m_scriptCachedMetadataTotalSize;
112 }; 112 };
113 113
114 DEFINE_TYPE_CASTS(ServiceWorkerGlobalScope, ExecutionContext, context, context-> isServiceWorkerGlobalScope(), context.isServiceWorkerGlobalScope()); 114 DEFINE_TYPE_CASTS(ServiceWorkerGlobalScope, ExecutionContext, context, context-> isServiceWorkerGlobalScope(), context.isServiceWorkerGlobalScope());
115 115
116 } // namespace blink 116 } // namespace blink
117 117
118 #endif // ServiceWorkerGlobalScope_h 118 #endif // ServiceWorkerGlobalScope_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698