Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 const AtomicString& interfaceName() const override; 111 const AtomicString& interfaceName() const override;
112 112
113 // ActiveDOMObject interface. 113 // ActiveDOMObject interface.
114 void stop() override; 114 void stop() override;
115 bool hasPendingActivity() const override; 115 bool hasPendingActivity() const override;
116 116
117 DECLARE_VIRTUAL_TRACE(); 117 DECLARE_VIRTUAL_TRACE();
118 118
119 protected: 119 protected:
120 // EventTarget interface. 120 // EventTarget interface.
121 bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) final; 121 DispatchEventResult dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) fin al;
122 122
123 private: 123 private:
124 Notification(ExecutionContext*, const WebNotificationData&); 124 Notification(ExecutionContext*, const WebNotificationData&);
125 125
126 void scheduleShow(); 126 void scheduleShow();
127 127
128 // Calling show() may start asynchronous operation. If this object has 128 // Calling show() may start asynchronous operation. If this object has
129 // a V8 wrapper, hasPendingActivity() prevents the wrapper from being 129 // a V8 wrapper, hasPendingActivity() prevents the wrapper from being
130 // collected while m_state is Showing, and so this instance stays alive 130 // collected while m_state is Showing, and so this instance stays alive
131 // until the operation completes. Otherwise, you need to hold a ref on this 131 // until the operation completes. Otherwise, you need to hold a ref on this
(...skipping 24 matching lines...) Expand all
156 void setState(NotificationState state) { m_state = state; } 156 void setState(NotificationState state) { m_state = state; }
157 157
158 NotificationState m_state; 158 NotificationState m_state;
159 159
160 Member<AsyncMethodRunner<Notification>> m_asyncRunner; 160 Member<AsyncMethodRunner<Notification>> m_asyncRunner;
161 }; 161 };
162 162
163 } // namespace blink 163 } // namespace blink
164 164
165 #endif // Notification_h 165 #endif // Notification_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698