Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 345
346 size_t Notification::maxActions() 346 size_t Notification::maxActions()
347 { 347 {
348 // Returns a fixed number for unit tests, which run without the availability of the Platform object. 348 // Returns a fixed number for unit tests, which run without the availability of the Platform object.
349 if (!notificationManager()) 349 if (!notificationManager())
350 return 2; 350 return 2;
351 351
352 return notificationManager()->maxActions(); 352 return notificationManager()->maxActions();
353 } 353 }
354 354
355 bool Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 355 DispatchEventResult Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<E vent> event)
356 { 356 {
357 ASSERT(executionContext()->isContextThread()); 357 ASSERT(executionContext()->isContextThread());
358 return EventTarget::dispatchEventInternal(event); 358 return EventTarget::dispatchEventInternal(event);
359 } 359 }
360 360
361 const AtomicString& Notification::interfaceName() const 361 const AtomicString& Notification::interfaceName() const
362 { 362 {
363 return EventTargetNames::Notification; 363 return EventTargetNames::Notification;
364 } 364 }
365 365
(...skipping 12 matching lines...) Expand all
378 } 378 }
379 379
380 DEFINE_TRACE(Notification) 380 DEFINE_TRACE(Notification)
381 { 381 {
382 visitor->trace(m_asyncRunner); 382 visitor->trace(m_asyncRunner);
383 RefCountedGarbageCollectedEventTargetWithInlineData<Notification>::trace(vis itor); 383 RefCountedGarbageCollectedEventTargetWithInlineData<Notification>::trace(vis itor);
384 ActiveDOMObject::trace(visitor); 384 ActiveDOMObject::trace(visitor);
385 } 385 }
386 386
387 } // namespace blink 387 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698