Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 127
128 protected: 128 protected:
129 IDBRequest(ScriptState*, IDBAny* source, IDBTransaction*); 129 IDBRequest(ScriptState*, IDBAny* source, IDBTransaction*);
130 void enqueueEvent(PassRefPtrWillBeRawPtr<Event>); 130 void enqueueEvent(PassRefPtrWillBeRawPtr<Event>);
131 void dequeueEvent(Event*); 131 void dequeueEvent(Event*);
132 virtual bool shouldEnqueueEvent() const; 132 virtual bool shouldEnqueueEvent() const;
133 void onSuccessInternal(IDBAny*); 133 void onSuccessInternal(IDBAny*);
134 void setResult(IDBAny*); 134 void setResult(IDBAny*);
135 135
136 // EventTarget 136 // EventTarget
137 bool dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) override; 137 DispatchEventResult dispatchEventInternal(PassRefPtrWillBeRawPtr<Event>) ove rride;
138 138
139 bool m_contextStopped = false; 139 bool m_contextStopped = false;
140 Member<IDBTransaction> m_transaction; 140 Member<IDBTransaction> m_transaction;
141 ReadyState m_readyState = PENDING; 141 ReadyState m_readyState = PENDING;
142 bool m_requestAborted = false; // May be aborted by transaction then receive async onsuccess; ignore vs. assert. 142 bool m_requestAborted = false; // May be aborted by transaction then receive async onsuccess; ignore vs. assert.
143 143
144 private: 144 private:
145 void setResultCursor(IDBCursor*, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDB Value>); 145 void setResultCursor(IDBCursor*, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDB Value>);
146 void ackReceivedBlobs(const IDBValue*); 146 void ackReceivedBlobs(const IDBValue*);
147 void ackReceivedBlobs(const Vector<RefPtr<IDBValue>>&); 147 void ackReceivedBlobs(const Vector<RefPtr<IDBValue>>&);
(...skipping 17 matching lines...) Expand all
165 RefPtr<IDBValue> m_cursorValue; 165 RefPtr<IDBValue> m_cursorValue;
166 166
167 bool m_didFireUpgradeNeededEvent = false; 167 bool m_didFireUpgradeNeededEvent = false;
168 bool m_preventPropagation = false; 168 bool m_preventPropagation = false;
169 bool m_resultDirty = true; 169 bool m_resultDirty = true;
170 }; 170 };
171 171
172 } // namespace blink 172 } // namespace blink
173 173
174 #endif // IDBRequest_h 174 #endif // IDBRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698