Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/input/PointerEventManager.h" 5 #include "core/input/PointerEventManager.h"
6 6
7 #include "core/dom/shadow/FlatTreeTraversal.h" 7 #include "core/dom/shadow/FlatTreeTraversal.h"
8 #include "core/events/MouseEvent.h" 8 #include "core/events/MouseEvent.h"
9 #include "core/input/EventHandler.h" 9 #include "core/input/EventHandler.h"
10 10
(...skipping 28 matching lines...) Expand all
39 WebInputEventResult dispatchPointerEvent( 39 WebInputEventResult dispatchPointerEvent(
40 PassRefPtrWillBeRawPtr<EventTarget> prpTarget, 40 PassRefPtrWillBeRawPtr<EventTarget> prpTarget,
41 PassRefPtrWillBeRawPtr<PointerEvent> prpPointerEvent, 41 PassRefPtrWillBeRawPtr<PointerEvent> prpPointerEvent,
42 bool checkForListener = false) 42 bool checkForListener = false)
43 { 43 {
44 RefPtrWillBeRawPtr<EventTarget> target = prpTarget; 44 RefPtrWillBeRawPtr<EventTarget> target = prpTarget;
45 RefPtrWillBeRawPtr<PointerEvent> pointerEvent = prpPointerEvent; 45 RefPtrWillBeRawPtr<PointerEvent> pointerEvent = prpPointerEvent;
46 if (!RuntimeEnabledFeatures::pointerEventEnabled()) 46 if (!RuntimeEnabledFeatures::pointerEventEnabled())
47 return WebInputEventResult::NotHandled; 47 return WebInputEventResult::NotHandled;
48 if (!checkForListener || target->hasEventListeners(pointerEvent->type())) { 48 if (!checkForListener || target->hasEventListeners(pointerEvent->type())) {
49 bool dispatchResult = target->dispatchEvent(pointerEvent); 49 DispatchEventResult dispatchResult = target->dispatchEvent(pointerEvent) ;
50 return EventHandler::eventToEventResult(pointerEvent, dispatchResult); 50 return EventHandler::toWebInputEventResult(dispatchResult);
51 } 51 }
52 return WebInputEventResult::NotHandled; 52 return WebInputEventResult::NotHandled;
53 } 53 }
54 54
55 WebInputEventResult dispatchMouseEvent( 55 WebInputEventResult dispatchMouseEvent(
56 PassRefPtrWillBeRawPtr<EventTarget> prpTarget, 56 PassRefPtrWillBeRawPtr<EventTarget> prpTarget,
57 const AtomicString& mouseEventType, 57 const AtomicString& mouseEventType,
58 const PlatformMouseEvent& mouseEvent, 58 const PlatformMouseEvent& mouseEvent,
59 PassRefPtrWillBeRawPtr<EventTarget> prpRelatedTarget, 59 PassRefPtrWillBeRawPtr<EventTarget> prpRelatedTarget,
60 int detail = 0, 60 int detail = 0,
61 bool checkForListener = false) 61 bool checkForListener = false)
62 { 62 {
63 RefPtrWillBeRawPtr<EventTarget> target = prpTarget; 63 RefPtrWillBeRawPtr<EventTarget> target = prpTarget;
64 RefPtrWillBeRawPtr<EventTarget> relatedTarget = prpRelatedTarget; 64 RefPtrWillBeRawPtr<EventTarget> relatedTarget = prpRelatedTarget;
65 if (target->toNode() 65 if (target->toNode()
66 && (!checkForListener || target->hasEventListeners(mouseEventType))) { 66 && (!checkForListener || target->hasEventListeners(mouseEventType))) {
67 RefPtrWillBeRawPtr<Node> targetNode = target->toNode(); 67 RefPtrWillBeRawPtr<Node> targetNode = target->toNode();
68 RefPtrWillBeRawPtr<MouseEvent> event = MouseEvent::create(mouseEventType , 68 RefPtrWillBeRawPtr<MouseEvent> event = MouseEvent::create(mouseEventType ,
69 targetNode->document().domWindow(), mouseEvent, detail, 69 targetNode->document().domWindow(), mouseEvent, detail,
70 relatedTarget ? relatedTarget->toNode() : nullptr); 70 relatedTarget ? relatedTarget->toNode() : nullptr);
71 bool res = target->dispatchEvent(event); 71 DispatchEventResult dispatchResult = target->dispatchEvent(event);
72 return EventHandler::eventToEventResult(event, res); 72 return EventHandler::toWebInputEventResult(dispatchResult);
73 } 73 }
74 return WebInputEventResult::NotHandled; 74 return WebInputEventResult::NotHandled;
75 } 75 }
76 76
77 } // namespace 77 } // namespace
78 78
79 PassRefPtrWillBeRawPtr<Node> PointerEventManager::getEffectiveTargetForPointerEv ent( 79 PassRefPtrWillBeRawPtr<Node> PointerEventManager::getEffectiveTargetForPointerEv ent(
80 PassRefPtrWillBeRawPtr<Node> target, 80 PassRefPtrWillBeRawPtr<Node> target,
81 PassRefPtrWillBeRawPtr<PointerEvent> pointerEvent) 81 PassRefPtrWillBeRawPtr<PointerEvent> pointerEvent)
82 { 82 {
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 337
338 DEFINE_TRACE(PointerEventManager) 338 DEFINE_TRACE(PointerEventManager)
339 { 339 {
340 #if ENABLE(OILPAN) 340 #if ENABLE(OILPAN)
341 visitor->trace(m_nodeUnderPointer); 341 visitor->trace(m_nodeUnderPointer);
342 #endif 342 #endif
343 } 343 }
344 344
345 345
346 } // namespace blink 346 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/page/ContextMenuController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698