Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionEditor.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef SelectionEditor_h 26 #ifndef SelectionEditor_h
27 #define SelectionEditor_h 27 #define SelectionEditor_h
28 28
29 #include "core/editing/FrameSelection.h" 29 #include "core/editing/FrameSelection.h"
30 #include "core/events/EventDispatchResult.h"
30 31
31 namespace blink { 32 namespace blink {
32 33
33 class SelectionEditor final : public NoBaseWillBeGarbageCollectedFinalized<Selec tionEditor>, public VisibleSelectionChangeObserver { 34 class SelectionEditor final : public NoBaseWillBeGarbageCollectedFinalized<Selec tionEditor>, public VisibleSelectionChangeObserver {
34 WTF_MAKE_NONCOPYABLE(SelectionEditor); 35 WTF_MAKE_NONCOPYABLE(SelectionEditor);
35 USING_FAST_MALLOC_WILL_BE_REMOVED(SelectionEditor); 36 USING_FAST_MALLOC_WILL_BE_REMOVED(SelectionEditor);
36 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SelectionEditor); 37 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(SelectionEditor);
37 public: 38 public:
38 // TODO(yosin) We should move |EAlteration| and |VerticalDirection| out 39 // TODO(yosin) We should move |EAlteration| and |VerticalDirection| out
39 // from |FrameSelection| class like |EUserTriggered|. 40 // from |FrameSelection| class like |EUserTriggered|.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 VisiblePosition modifyMovingForward(TextGranularity); 105 VisiblePosition modifyMovingForward(TextGranularity);
105 VisiblePosition modifyExtendingLeft(TextGranularity); 106 VisiblePosition modifyExtendingLeft(TextGranularity);
106 VisiblePosition modifyExtendingBackward(TextGranularity); 107 VisiblePosition modifyExtendingBackward(TextGranularity);
107 VisiblePosition modifyMovingLeft(TextGranularity); 108 VisiblePosition modifyMovingLeft(TextGranularity);
108 VisiblePosition modifyMovingBackward(TextGranularity); 109 VisiblePosition modifyMovingBackward(TextGranularity);
109 110
110 void startObservingVisibleSelectionChange(); 111 void startObservingVisibleSelectionChange();
111 void stopObservingVisibleSelectionChangeIfNecessary(); 112 void stopObservingVisibleSelectionChangeIfNecessary();
112 113
113 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType); 114 LayoutUnit lineDirectionPointForBlockDirectionNavigation(EPositionType);
114 bool dispatchSelectStart(); 115 DispatchEventResult dispatchSelectStart();
115 116
116 RawPtrWillBeMember<FrameSelection> m_frameSelection; 117 RawPtrWillBeMember<FrameSelection> m_frameSelection;
117 118
118 LayoutUnit m_xPosForVerticalArrowNavigation; 119 LayoutUnit m_xPosForVerticalArrowNavigation;
119 VisibleSelection m_selection; 120 VisibleSelection m_selection;
120 VisibleSelectionInFlatTree m_selectionInFlatTree; 121 VisibleSelectionInFlatTree m_selectionInFlatTree;
121 bool m_observingVisibleSelection; 122 bool m_observingVisibleSelection;
122 123
123 // The range specified by the user, which may not be visually canonicalized 124 // The range specified by the user, which may not be visually canonicalized
124 // (hence "logical"). This will be invalidated if the underlying 125 // (hence "logical"). This will be invalidated if the underlying
125 // |VisibleSelection| changes. If that happens, this variable will 126 // |VisibleSelection| changes. If that happens, this variable will
126 // become |nullptr|, in which case logical positions == visible positions. 127 // become |nullptr|, in which case logical positions == visible positions.
127 RefPtrWillBeMember<Range> m_logicalRange; 128 RefPtrWillBeMember<Range> m_logicalRange;
128 }; 129 };
129 130
130 } // namespace blink 131 } // namespace blink
131 132
132 #endif // SelectionEditor_h 133 #endif // SelectionEditor_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698