Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix typo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 } 649 }
650 650
651 void Animation::stop() 651 void Animation::stop()
652 { 652 {
653 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand); 653 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand);
654 654
655 m_finished = true; 655 m_finished = true;
656 m_pendingFinishedEvent = nullptr; 656 m_pendingFinishedEvent = nullptr;
657 } 657 }
658 658
659 bool Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 659 DispatchEventResult Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Even t> event)
660 { 660 {
661 if (m_pendingFinishedEvent == event) 661 if (m_pendingFinishedEvent == event)
662 m_pendingFinishedEvent = nullptr; 662 m_pendingFinishedEvent = nullptr;
663 return EventTargetWithInlineData::dispatchEventInternal(event); 663 return EventTargetWithInlineData::dispatchEventInternal(event);
664 } 664 }
665 665
666 double Animation::playbackRate() const 666 double Animation::playbackRate() const
667 { 667 {
668 return m_playbackRate; 668 return m_playbackRate;
669 } 669 }
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1082 visitor->trace(m_timeline); 1082 visitor->trace(m_timeline);
1083 visitor->trace(m_pendingFinishedEvent); 1083 visitor->trace(m_pendingFinishedEvent);
1084 visitor->trace(m_pendingCancelledEvent); 1084 visitor->trace(m_pendingCancelledEvent);
1085 visitor->trace(m_finishedPromise); 1085 visitor->trace(m_finishedPromise);
1086 visitor->trace(m_readyPromise); 1086 visitor->trace(m_readyPromise);
1087 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r); 1087 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r);
1088 ActiveDOMObject::trace(visitor); 1088 ActiveDOMObject::trace(visitor);
1089 } 1089 }
1090 1090
1091 } // namespace blink 1091 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/Animation.h ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698