Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/core/events/Event.h

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Fix comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de) 3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 // ErrorEvent behaves, can override this method. 194 // ErrorEvent behaves, can override this method.
195 virtual bool canBeDispatchedInWorld(const DOMWrapperWorld&) const { return t rue; } 195 virtual bool canBeDispatchedInWorld(const DOMWrapperWorld&) const { return t rue; }
196 196
197 virtual PassRefPtrWillBeRawPtr<EventDispatchMediator> createMediator(); 197 virtual PassRefPtrWillBeRawPtr<EventDispatchMediator> createMediator();
198 198
199 bool isTrusted() const { return m_isTrusted; } 199 bool isTrusted() const { return m_isTrusted; }
200 void setTrusted(bool value) { m_isTrusted = value; } 200 void setTrusted(bool value) { m_isTrusted = value; }
201 201
202 void setHandlingPassive(bool value) { m_handlingPassive = value; } 202 void setHandlingPassive(bool value) { m_handlingPassive = value; }
203 203
204 DispatchEventResult eventResult() const
philipj_slow 2016/02/25 15:23:46 dispatchEventResult or dispatchResult? The result
dtapuska 2016/02/25 22:06:10 Done.
205 {
206 if (defaultPrevented())
207 return DispatchEventResult::CanceledByEventHandler;
208 if (defaultHandled())
209 return DispatchEventResult::CanceledByDefaultEventHandler;
210 return DispatchEventResult::NotCanceled;
211 }
212
204 DECLARE_VIRTUAL_TRACE(); 213 DECLARE_VIRTUAL_TRACE();
205 214
206 protected: 215 protected:
207 Event(); 216 Event();
208 Event(const AtomicString& type, bool canBubble, bool cancelable); 217 Event(const AtomicString& type, bool canBubble, bool cancelable);
209 Event(const AtomicString& type, bool canBubble, bool cancelable, double plat formTimeStamp); 218 Event(const AtomicString& type, bool canBubble, bool cancelable, double plat formTimeStamp);
210 Event(const AtomicString& type, bool canBubble, bool cancelable, bool scoped ); 219 Event(const AtomicString& type, bool canBubble, bool cancelable, bool scoped );
211 Event(const AtomicString& type, bool canBubble, bool cancelable, bool scoped , double platformTimeStamp); 220 Event(const AtomicString& type, bool canBubble, bool cancelable, bool scoped , double platformTimeStamp);
212 Event(const AtomicString& type, const EventInit&); 221 Event(const AtomicString& type, const EventInit&);
213 222
(...skipping 27 matching lines...) Expand all
241 // WebInputEvent instance. 250 // WebInputEvent instance.
242 double m_platformTimeStamp; 251 double m_platformTimeStamp;
243 }; 252 };
244 253
245 #define DEFINE_EVENT_TYPE_CASTS(typeName) \ 254 #define DEFINE_EVENT_TYPE_CASTS(typeName) \
246 DEFINE_TYPE_CASTS(typeName, Event, event, event->is##typeName(), event.is##t ypeName()) 255 DEFINE_TYPE_CASTS(typeName, Event, event, event->is##typeName(), event.is##t ypeName())
247 256
248 } // namespace blink 257 } // namespace blink
249 258
250 #endif // Event_h 259 #endif // Event_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698