Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Rename enum values Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 } 650 }
651 651
652 void Animation::stop() 652 void Animation::stop()
653 { 653 {
654 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand); 654 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand);
655 655
656 m_finished = true; 656 m_finished = true;
657 m_pendingFinishedEvent = nullptr; 657 m_pendingFinishedEvent = nullptr;
658 } 658 }
659 659
660 bool Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 660 DispatchEventResult Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Even t> event)
661 { 661 {
662 if (m_pendingFinishedEvent == event) 662 if (m_pendingFinishedEvent == event)
663 m_pendingFinishedEvent = nullptr; 663 m_pendingFinishedEvent = nullptr;
664 return EventTargetWithInlineData::dispatchEventInternal(event); 664 return EventTargetWithInlineData::dispatchEventInternal(event);
665 } 665 }
666 666
667 double Animation::playbackRate() const 667 double Animation::playbackRate() const
668 { 668 {
669 return m_playbackRate; 669 return m_playbackRate;
670 } 670 }
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1083 visitor->trace(m_timeline); 1083 visitor->trace(m_timeline);
1084 visitor->trace(m_pendingFinishedEvent); 1084 visitor->trace(m_pendingFinishedEvent);
1085 visitor->trace(m_pendingCancelledEvent); 1085 visitor->trace(m_pendingCancelledEvent);
1086 visitor->trace(m_finishedPromise); 1086 visitor->trace(m_finishedPromise);
1087 visitor->trace(m_readyPromise); 1087 visitor->trace(m_readyPromise);
1088 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r); 1088 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r);
1089 ActiveDOMObject::trace(visitor); 1089 ActiveDOMObject::trace(visitor);
1090 } 1090 }
1091 1091
1092 } // namespace blink 1092 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698