Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Add back the EventDispatchResult enum Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 } 626 }
627 627
628 void Animation::stop() 628 void Animation::stop()
629 { 629 {
630 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand); 630 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand);
631 631
632 m_finished = true; 632 m_finished = true;
633 m_pendingFinishedEvent = nullptr; 633 m_pendingFinishedEvent = nullptr;
634 } 634 }
635 635
636 bool Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 636 EventTarget::DispatchEventResult Animation::dispatchEventInternal(PassRefPtrWill BeRawPtr<Event> event)
637 { 637 {
638 if (m_pendingFinishedEvent == event) 638 if (m_pendingFinishedEvent == event)
639 m_pendingFinishedEvent = nullptr; 639 m_pendingFinishedEvent = nullptr;
640 return EventTargetWithInlineData::dispatchEventInternal(event); 640 return EventTargetWithInlineData::dispatchEventInternal(event);
641 } 641 }
642 642
643 double Animation::playbackRate() const 643 double Animation::playbackRate() const
644 { 644 {
645 return m_playbackRate; 645 return m_playbackRate;
646 } 646 }
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1059 visitor->trace(m_timeline); 1059 visitor->trace(m_timeline);
1060 visitor->trace(m_pendingFinishedEvent); 1060 visitor->trace(m_pendingFinishedEvent);
1061 visitor->trace(m_pendingCancelledEvent); 1061 visitor->trace(m_pendingCancelledEvent);
1062 visitor->trace(m_finishedPromise); 1062 visitor->trace(m_finishedPromise);
1063 visitor->trace(m_readyPromise); 1063 visitor->trace(m_readyPromise);
1064 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r); 1064 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r);
1065 ActiveDOMObject::trace(visitor); 1065 ActiveDOMObject::trace(visitor);
1066 } 1066 }
1067 1067
1068 } // namespace blink 1068 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698