Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 331
332 size_t Notification::maxActions() 332 size_t Notification::maxActions()
333 { 333 {
334 // Returns a fixed number for unit tests, which run without the availability of the Platform object. 334 // Returns a fixed number for unit tests, which run without the availability of the Platform object.
335 if (!notificationManager()) 335 if (!notificationManager())
336 return 2; 336 return 2;
337 337
338 return notificationManager()->maxActions(); 338 return notificationManager()->maxActions();
339 } 339 }
340 340
341 bool Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 341 WebInputEventResult Notification::dispatchEventInternal(PassRefPtrWillBeRawPtr<E vent> event)
342 { 342 {
343 ASSERT(executionContext()->isContextThread()); 343 ASSERT(executionContext()->isContextThread());
344 return EventTarget::dispatchEventInternal(event); 344 return EventTarget::dispatchEventInternal(event);
345 } 345 }
346 346
347 const AtomicString& Notification::interfaceName() const 347 const AtomicString& Notification::interfaceName() const
348 { 348 {
349 return EventTargetNames::Notification; 349 return EventTargetNames::Notification;
350 } 350 }
351 351
(...skipping 11 matching lines...) Expand all
363 return m_state == NotificationStateShowing || m_asyncRunner.isActive(); 363 return m_state == NotificationStateShowing || m_asyncRunner.isActive();
364 } 364 }
365 365
366 DEFINE_TRACE(Notification) 366 DEFINE_TRACE(Notification)
367 { 367 {
368 RefCountedGarbageCollectedEventTargetWithInlineData<Notification>::trace(vis itor); 368 RefCountedGarbageCollectedEventTargetWithInlineData<Notification>::trace(vis itor);
369 ActiveDOMObject::trace(visitor); 369 ActiveDOMObject::trace(visitor);
370 } 370 }
371 371
372 } // namespace blink 372 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698