Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: third_party/WebKit/Source/core/animation/Animation.cpp

Issue 1479923002: Enumerate the return value of dispatchEvent so it is clear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_passive_uma_add
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 } 625 }
626 626
627 void Animation::stop() 627 void Animation::stop()
628 { 628 {
629 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand); 629 PlayStateUpdateScope updateScope(*this, TimingUpdateOnDemand);
630 630
631 m_finished = true; 631 m_finished = true;
632 m_pendingFinishedEvent = nullptr; 632 m_pendingFinishedEvent = nullptr;
633 } 633 }
634 634
635 bool Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Event> event) 635 WebInputEventResult Animation::dispatchEventInternal(PassRefPtrWillBeRawPtr<Even t> event)
636 { 636 {
637 if (m_pendingFinishedEvent == event) 637 if (m_pendingFinishedEvent == event)
638 m_pendingFinishedEvent = nullptr; 638 m_pendingFinishedEvent = nullptr;
639 return EventTargetWithInlineData::dispatchEventInternal(event); 639 return EventTargetWithInlineData::dispatchEventInternal(event);
640 } 640 }
641 641
642 double Animation::playbackRate() const 642 double Animation::playbackRate() const
643 { 643 {
644 return m_playbackRate; 644 return m_playbackRate;
645 } 645 }
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
1087 visitor->trace(m_content); 1087 visitor->trace(m_content);
1088 visitor->trace(m_timeline); 1088 visitor->trace(m_timeline);
1089 visitor->trace(m_pendingFinishedEvent); 1089 visitor->trace(m_pendingFinishedEvent);
1090 visitor->trace(m_finishedPromise); 1090 visitor->trace(m_finishedPromise);
1091 visitor->trace(m_readyPromise); 1091 visitor->trace(m_readyPromise);
1092 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r); 1092 RefCountedGarbageCollectedEventTargetWithInlineData<Animation>::trace(visito r);
1093 ActiveDOMObject::trace(visitor); 1093 ActiveDOMObject::trace(visitor);
1094 } 1094 }
1095 1095
1096 } // namespace 1096 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698