Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14799005: Fix legacy UI in Files.app. (Closed)

Created:
7 years, 7 months ago by mtomasz
Modified:
7 years, 7 months ago
Reviewers:
yoshiki, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fix legacy UI in Files.app. This patch fixes javascript caused by performing operations on the middle panel which doesn't exist in the legacy UI. TEST=Run chrome in the legacy UI mode (about:flags or --file-manager-legacy) and run Files.app. BUG=240148 R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199657

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Patch Set 3 : Rebased. #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -28 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 3 1 chunk +13 lines, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 7 chunks +27 lines, -8 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_selection.js View 1 2 3 8 chunks +79 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@yoshiki, @hirono: PTAL. Thanks.
7 years, 7 months ago (2013-05-13 01:51:56 UTC) #1
yoshiki
https://codereview.chromium.org/14799005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/14799005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2545 chrome/browser/resources/file_manager/js/file_manager.js:2545: this.updateMiddleBarVisibility_(); This is necessary on New UI.
7 years, 7 months ago (2013-05-13 02:00:48 UTC) #2
mtomasz
https://codereview.chromium.org/14799005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/14799005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2545 chrome/browser/resources/file_manager/js/file_manager.js:2545: this.updateMiddleBarVisibility_(); On 2013/05/13 02:00:48, yoshiki wrote: > This is ...
7 years, 7 months ago (2013-05-13 02:07:38 UTC) #3
yoshiki
lgtm
7 years, 7 months ago (2013-05-13 02:59:38 UTC) #4
mtomasz
7 years, 7 months ago (2013-05-13 05:10:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r199657 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698