Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1479893002: Allocators for map<K, V> need to allocate pair<const K, V>. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allocators for map<K, V> need to allocate pair<const K, V>. BUG=chromium:562227 LOG=n Committed: https://crrev.com/96cb90983775bfce634271a70180fdd1bfc23099 Cr-Commit-Position: refs/heads/master@{#32360}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/instruction.h View 1 chunk +1 line, -1 line 0 comments Download
M src/zone-containers.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Nico
5 years ago (2015-11-26 21:33:25 UTC) #2
Nico
i checked that this lets me build v8 with trunk libc++ again. please hit cq ...
5 years ago (2015-11-27 01:05:43 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-27 08:22:32 UTC) #5
Benedikt Meurer
LGTM (rubberstamped)
5 years ago (2015-11-27 08:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479893002/1
5 years ago (2015-11-27 08:36:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 08:38:54 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-27 08:39:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96cb90983775bfce634271a70180fdd1bfc23099
Cr-Commit-Position: refs/heads/master@{#32360}

Powered by Google App Engine
This is Rietveld 408576698