Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1479863003: Split shape related measurements from SVG1DOM counter (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
Ilya Sherman, fs
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split shape related measurements from SVG1DOM counter Create a SVG1DOMShapes UseCounter to measure all shape/graphics element related SVG DOM functionality. The assumption we want to test is that the shape related SVG DOM has really low usage. BUG=415074 Committed: https://crrev.com/e16888d181947cd480acd6b29335c902944dc7d7 Cr-Commit-Position: refs/heads/master@{#362107}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCircleElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGEllipseElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLineElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPolygonElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPolylineElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479863003/1
5 years ago (2015-11-27 13:56:51 UTC) #2
davve
One more (last?) of the easy ones.
5 years ago (2015-11-27 13:57:00 UTC) #4
davve
... and isherman for histograms.xml.
5 years ago (2015-11-27 13:57:45 UTC) #6
fs
> It has been suggested that this might have higher usage than other SVG1DOM* counters. ...
5 years ago (2015-11-27 14:05:16 UTC) #7
davve
On 2015/11/27 14:05:16, fs wrote: > > It has been suggested that this might have ...
5 years ago (2015-11-27 14:08:39 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 15:21:18 UTC) #12
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-11-28 05:58:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479863003/1
5 years ago (2015-11-28 13:43:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/122950)
5 years ago (2015-11-28 13:51:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479863003/20001
5 years ago (2015-11-30 07:38:52 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 08:57:07 UTC) #22
commit-bot: I haz the power
5 years ago (2015-11-30 08:58:06 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e16888d181947cd480acd6b29335c902944dc7d7
Cr-Commit-Position: refs/heads/master@{#362107}

Powered by Google App Engine
This is Rietveld 408576698