Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1479843002: [debugger] Remove obsolete stepping modes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix one more test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.js ('k') | test/mjsunit/debug-continue.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
1225 StackFrame::Id frame_id; 1225 StackFrame::Id frame_id;
1226 if (wrapped_frame_id == 0) { 1226 if (wrapped_frame_id == 0) {
1227 frame_id = StackFrame::NO_ID; 1227 frame_id = StackFrame::NO_ID;
1228 } else { 1228 } else {
1229 frame_id = DebugFrameHelper::UnwrapFrameId(wrapped_frame_id); 1229 frame_id = DebugFrameHelper::UnwrapFrameId(wrapped_frame_id);
1230 } 1230 }
1231 1231
1232 // Get the step action and check validity. 1232 // Get the step action and check validity.
1233 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1])); 1233 StepAction step_action = static_cast<StepAction>(NumberToInt32(args[1]));
1234 if (step_action != StepIn && step_action != StepNext && 1234 if (step_action != StepIn && step_action != StepNext &&
1235 step_action != StepOut && step_action != StepInMin && 1235 step_action != StepOut && step_action != StepFrame) {
1236 step_action != StepMin && step_action != StepFrame) {
1237 return isolate->Throw(isolate->heap()->illegal_argument_string()); 1236 return isolate->Throw(isolate->heap()->illegal_argument_string());
1238 } 1237 }
1239 1238
1240 if (frame_id != StackFrame::NO_ID && step_action != StepNext && 1239 if (frame_id != StackFrame::NO_ID && step_action != StepNext &&
1241 step_action != StepMin && step_action != StepOut) { 1240 step_action != StepOut) {
1242 return isolate->ThrowIllegalOperation(); 1241 return isolate->ThrowIllegalOperation();
1243 } 1242 }
1244 1243
1245 // Get the number of steps. 1244 // Get the number of steps.
1246 int step_count = NumberToInt32(args[2]); 1245 int step_count = NumberToInt32(args[2]);
1247 if (step_count < 1) { 1246 if (step_count < 1) {
1248 return isolate->Throw(isolate->heap()->illegal_argument_string()); 1247 return isolate->Throw(isolate->heap()->illegal_argument_string());
1249 } 1248 }
1250 1249
1251 // Clear all current stepping setup. 1250 // Clear all current stepping setup.
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1751 return *isolate->factory()->undefined_value(); 1750 return *isolate->factory()->undefined_value();
1752 } 1751 }
1753 1752
1754 1753
1755 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1754 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1756 UNIMPLEMENTED(); 1755 UNIMPLEMENTED();
1757 return NULL; 1756 return NULL;
1758 } 1757 }
1759 } // namespace internal 1758 } // namespace internal
1760 } // namespace v8 1759 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.js ('k') | test/mjsunit/debug-continue.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698