Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1479843002: [debugger] Remove obsolete stepping modes. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Remove obsolete stepping modes. R=bmeurer@chromium.org Committed: https://crrev.com/a9bdee1f90506a3a384d562faf8fa7ac194e0c45 Cr-Commit-Position: refs/heads/master@{#32343}

Patch Set 1 #

Patch Set 2 : fix one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -38 lines) Patch
M src/debug/debug.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.js View 2 chunks +1 line, -5 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/debug-continue.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-stepout-scope-part1.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part2.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part3.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part4.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part5.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part6.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part7.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part8.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years ago (2015-11-26 13:44:48 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479843002/20001
5 years ago (2015-11-26 13:49:37 UTC) #3
Benedikt Meurer
LGTM.
5 years ago (2015-11-26 13:50:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 14:30:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479843002/20001
5 years ago (2015-11-26 14:31:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 14:34:17 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-26 14:34:50 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a9bdee1f90506a3a384d562faf8fa7ac194e0c45
Cr-Commit-Position: refs/heads/master@{#32343}

Powered by Google App Engine
This is Rietveld 408576698