Issue 147983011: Revert 247790 "Change default mode of extension install verifica..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147983011: Revert 247790 "Change default mode of extension install verifica..." (Closed)

Created:
6 years, 10 months ago by asargent_no_longer_on_chrome

Modified:
6 years, 10 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 247790 "Change default mode of extension install verifica..." > Change default mode of extension install verification > > Right now the default mode is to make requests against the server unless > the experiment group says not to, and that may be contributing to some > unexpected load we're seeing. So this CL changes it to not do that. > > It also adds some histograms to help measure the success rate and > sources of requests to the server. > > BUG=335379 > R=finnur@chromium.org > > Review URL: https://codereview.chromium.org/149353002 TBR=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247797

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -117 lines)			Patch
M	trunk/src/chrome/browser/extensions/extension_service.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_service.cc	View	5 chunks	+5 lines, -36 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/install_signer.cc	View	6 chunks	+7 lines, -60 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/install_verifier.cc	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

6 years, 10 months ago (2014-01-30 01:20:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r247797.

Expand Messages | Collapse Messages