Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14798004: path ops -- fix skp bugs (Closed)

Created:
7 years, 7 months ago by caryclark
Modified:
7 years, 7 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

path ops -- fix skp bugs This fixes a series of bugs discovered by running the small set of Skia skp files through pathops to flatten the clips. Committed: https://code.google.com/p/skia/source/detail?r=9042

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+839 lines, -212 lines) Patch
M gyp/pathops_unittest.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkAddIntersections.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkDCubicIntersection.cpp View 1 5 chunks +55 lines, -43 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 1 1 chunk +0 lines, -21 lines 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/pathops/SkIntersections.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 5 chunks +71 lines, -20 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpContour.cpp View 1 2 chunks +10 lines, -13 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 11 chunks +38 lines, -8 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 7 chunks +14 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 chunks +63 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 4 chunks +14 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsPoint.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 3 chunks +8 lines, -4 lines 0 comments Download
M src/pathops/SkPathWriter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathWriter.cpp View 1 3 chunks +10 lines, -1 line 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 2 chunks +49 lines, -21 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
A tests/PathOpsCubicQuadIntersectionTest.cpp View 1 chunk +71 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 6 chunks +6 lines, -5 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 1 3 chunks +47 lines, -9 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 chunks +198 lines, -45 lines 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 chunks +84 lines, -1 line 0 comments Download
A tests/PathOpsSkpClipTest.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M tests/PathOpsThreadedCommon.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/PathOpsThreadedCommon.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caryclark
7 years, 7 months ago (2013-05-07 18:51:49 UTC) #1
Message was sent while issue was closed. 
Committed patchset #2 manually as r9042 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698