Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1479793003: [turbofan] Properly wire effects for JSLoadContext and JSStoreContext. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly wire effects for JSLoadContext and JSStoreContext. The effect chain should be respected for context loads and stores. R=mstarzinger@chromium.org Committed: https://crrev.com/e3ecfdfecc2a37f736918a1d5e6ab93f7334a048 Cr-Commit-Position: refs/heads/master@{#32363}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 chunks +15 lines, -14 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
5 years ago (2015-11-26 14:16:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479793003/1
5 years ago (2015-11-26 17:48:16 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/12330)
5 years ago (2015-11-26 17:59:48 UTC) #5
Michael Starzinger
LGTM modulo unit tests.
5 years ago (2015-11-27 08:59:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479793003/20001
5 years ago (2015-11-27 09:00:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 09:22:25 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-27 09:23:00 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3ecfdfecc2a37f736918a1d5e6ab93f7334a048
Cr-Commit-Position: refs/heads/master@{#32363}

Powered by Google App Engine
This is Rietveld 408576698