Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1479773002: Remove custom win64 modulo code (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove custom win64 modulo code Just use the same workaround as on win32. Also replace fmod calls with modulo() for consistency BUG=none R=yangguo@chromium.org LOG=n Committed: https://crrev.com/ed841139dff6a0ca1c76ad47e06d3f694a6b6c3b Cr-Commit-Position: refs/heads/master@{#32322}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -118 lines) Patch
M src/arm64/simulator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/codegen.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M src/conversions.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-26 09:31:14 UTC) #1
Yang
On 2015/11/26 09:31:14, jochen wrote: lgtm if tests pass.
5 years ago (2015-11-26 09:39:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479773002/20001
5 years ago (2015-11-26 09:47:05 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 10:11:45 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-26 10:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed841139dff6a0ca1c76ad47e06d3f694a6b6c3b
Cr-Commit-Position: refs/heads/master@{#32322}

Powered by Google App Engine
This is Rietveld 408576698