Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1479723002: Revert of DevTools: Make tracking entry info on flame chart work with pan/zoom. (Closed)

Created:
5 years ago by alph
Modified:
5 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Make tracking entry info on flame chart work with pan/zoom. (patchset #3 id:40001 of https://codereview.chromium.org/1468163003/ ) Reason for revert: Broke item selection on flamechart. Original issue's description: > DevTools: Make tracking entry info on flame chart work with pan/zoom. > > BUG=528489 > > Committed: https://crrev.com/0c3db54e48b8e3a569dad3b72bfc0d45517855fa > Cr-Commit-Position: refs/heads/master@{#361354} TBR=caseq@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528489 Committed: https://crrev.com/7645167c8d94d23da041a9fef24ea13e8dad48ca Cr-Commit-Position: refs/heads/master@{#361754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alph
Created Revert of DevTools: Make tracking entry info on flame chart work with pan/zoom.
5 years ago (2015-11-26 00:22:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479723002/1
5 years ago (2015-11-26 00:22:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 00:25:39 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-26 00:26:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7645167c8d94d23da041a9fef24ea13e8dad48ca
Cr-Commit-Position: refs/heads/master@{#361754}

Powered by Google App Engine
This is Rietveld 408576698