Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1479713003: [turbofan] Implemented the TruncateFloat32ToUint64 TurboFan operator. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer, v8-arm-ports
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implemented the TruncateFloat32ToUint64 TurboFan operator. The TruncateFloat32ToUint64 operator converts a float32 to an uint64 using round-to-zero rounding mode. If the input value is outside uint64 range, then the result depends on the architecture. I provide an implementation for x64 and arm64. R=titzer@chromium.org Committed: https://crrev.com/68cc0be2ad75c698d08d6672b69ad9649418cd9f Cr-Commit-Position: refs/heads/master@{#32379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ahaas
5 years ago (2015-11-26 18:38:38 UTC) #1
titzer
On 2015/11/26 18:38:38, ahaas wrote: lgtm
5 years ago (2015-11-27 14:32:49 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479713003/1
5 years ago (2015-11-27 14:34:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 14:35:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479713003/1
5 years ago (2015-11-27 15:00:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 15:01:40 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-27 15:01:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68cc0be2ad75c698d08d6672b69ad9649418cd9f
Cr-Commit-Position: refs/heads/master@{#32379}

Powered by Google App Engine
This is Rietveld 408576698