Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1479703002: base: Remove move_unittest.cc (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove move_unittest.cc This test is basically checking that the MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro adds a Pass() function. This seems pretty overkill at this point. R=thakis@chromium.org BUG=557422 Committed: https://crrev.com/d0b25cca96a62beb013ecb0c4d084c524f5a908c Cr-Commit-Position: refs/heads/master@{#362236}

Patch Set 1 #

Patch Set 2 : move-only-2: . #

Patch Set 3 : move-only-2: remove-it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M base/move_unittest.cc View 1 2 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
danakj
5 years ago (2015-11-26 00:05:08 UTC) #1
danakj
Actually I'm not sure what the point of this unit test is besides checking that ...
5 years ago (2015-11-26 00:11:02 UTC) #2
danakj
Killed it.
5 years ago (2015-11-26 00:12:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479703002/40001
5 years ago (2015-11-26 00:38:44 UTC) #6
Nico
lgtm
5 years ago (2015-11-26 02:30:18 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-26 02:43:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479703002/40001
5 years ago (2015-11-30 19:37:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-30 22:12:34 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 22:13:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0b25cca96a62beb013ecb0c4d084c524f5a908c
Cr-Commit-Position: refs/heads/master@{#362236}

Powered by Google App Engine
This is Rietveld 408576698