Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1479623002: Revert of [tools/perf] Add smoke test cover for record_wpr list command (Closed)

Created:
5 years ago by brucedawson
Modified:
5 years ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [tools/perf] Add smoke test cover for record_wpr list command (patchset #1 id:1 of https://codereview.chromium.org/1477793002/ ) Reason for revert: Failure in android_tests_dbg, self.assertIn('kraken', stdout) AssertionError: 'kraken' not found in https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/31510/steps/telemetry_perf_unittests/logs/stdio (bruce the sheriff) Original issue's description: > [tools/perf] Add smoke test cover for record_wpr list command > > This should catch the breakage which https://codereview.chromium.org/1476783002/ > fixes. > > BUG=561431 > > Committed: https://crrev.com/f1f30e79215858247293e6006e1f53b3b8d84209 > Cr-Commit-Position: refs/heads/master@{#361702} TBR=perezju@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561431 Committed: https://crrev.com/6180445aa9c777ae4f8a5ee20cfddde3fcd26a73 Cr-Commit-Position: refs/heads/master@{#361718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/perf/scripts_smoke_unittest.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
brucedawson
Created Revert of [tools/perf] Add smoke test cover for record_wpr list command
5 years ago (2015-11-25 19:32:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479623002/1
5 years ago (2015-11-25 19:35:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:37:38 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-25 19:39:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6180445aa9c777ae4f8a5ee20cfddde3fcd26a73
Cr-Commit-Position: refs/heads/master@{#361718}

Powered by Google App Engine
This is Rietveld 408576698