Cleanup: Deprecate FileSystemCallbackDispatcher

webkit/fileapi/webfilewriter_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_WEBFILEWRITER_BASE_H_
 #define WEBKIT_FILEAPI_WEBFILEWRITER_BASE_H_
 
 #include "base/platform_file.h"
 #include "googleurl/src/gurl.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFileWriter.h"
@@ skipping 11 matching lines @@
  public:
   WebFileWriterBase(
       const GURL& path, WebKit::WebFileWriterClient* client);
   virtual ~WebFileWriterBase();
 
   // WebFileWriter implementation
   virtual void truncate(long long length);
   virtual void write(long long position, const WebKit::WebURL& blobURL);
   virtual void cancel();
 
+  void DidFinish(base::PlatformFileError error_code);
+  void DidWrite(int64 bytes, bool complete);

[michaeln, 2013/05/15 20:18:26]

do these need to be public now?

[kinuko, 2013/05/16 09:29:38]

Made them protected.

+
  protected:
+  void DidSucceed();
+  void DidFail(base::PlatformFileError error_code);
+
   // Derived classes must provide these methods to asynchronously perform
   // the requested operation, and they must call the appropiate DidSomething
   // method upon completion and as progress is made in the Write case.
   virtual void DoTruncate(const GURL& path, int64 offset) = 0;
   virtual void DoWrite(const GURL& path, const GURL& blob_url,
                        int64 offset) = 0;
   virtual void DoCancel() = 0;
 
-  void DidSucceed();
-  void DidFail(base::PlatformFileError error_code);
-  void DidWrite(int64 bytes, bool complete);
-
  private:
   enum OperationType {
     kOperationNone,
     kOperationWrite,
     kOperationTruncate
   };
 
   enum CancelState {
     kCancelNotInProgress,
     kCancelSent,
     kCancelReceivedWriteResponse,
   };
 
   void FinishCancel();
 
   GURL path_;
   WebKit::WebFileWriterClient* client_;
   OperationType operation_;
   CancelState cancel_state_;
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_WEBFILEWRITER_BASE_H_