Cleanup: Deprecate FileSystemCallbackDispatcher

content/renderer/pepper/pepper_file_system_host.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_FILE_SYSTEM_HOST_H_
 #define CONTENT_RENDERER_PEPPER_PEPPER_FILE_SYSTEM_HOST_H_
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "googleurl/src/gurl.h"
@@ skipping 18 matching lines @@
   // ppapi::host::ResourceHost override.
   virtual int32_t OnResourceMessageReceived(
       const IPC::Message& msg,
       ppapi::host::HostMessageContext* context) OVERRIDE;
 
   // Supports FileRefs direct access on the host side.
   PP_FileSystemType GetType() const { return type_; }
   bool IsOpened() const { return opened_; }
   GURL GetRootUrl() const { return root_url_; }
 
-  // It's public only to allow PlatformCallbackAdaptor to access.
-  void OpenFileSystemReply(int32_t pp_error,
+  // Callback for OpenFileSystem.
+  void OpenFileSystemReply(base::PlatformFileError platform_error,

[yzshen1, 2013/05/14 16:50:09]

nit: It could be moved to the private section.

[kinuko, 2013/05/15 13:58:03]

Hmm, looks like this needs to be public as it's called from outside of this
class in the end.

[yzshen1, 2013/05/15 18:13:54]

I think they could be private since they are base::Bind()-ed in this class.
Right?

On 2013/05/15 13:58:03, kinuko wrote:

+                           const std::string& name_unused,
                            const GURL& root);
 
  private:
   int32_t OnHostMsgOpen(ppapi::host::HostMessageContext* context,
                         int64_t expected_size);
   int32_t OnHostMsgInitIsolatedFileSystem(
       ppapi::host::HostMessageContext* context,
       const std::string& fsid);
 
   RendererPpapiHost* renderer_ppapi_host_;
   ppapi::host::ReplyMessageContext reply_context_;
   base::WeakPtrFactory<PepperFileSystemHost> weak_factory_;
 
   PP_FileSystemType type_;
   bool opened_;  // whether open is successful.
   GURL root_url_;
   bool called_open_;  // whether open has been called.
 
   DISALLOW_COPY_AND_ASSIGN(PepperFileSystemHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PEPPER_FILE_SYSTEM_HOST_H_