Parallel compilation fix: the optimizer thread shouldn't change the allow allocation state on Asser…

src/heap-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 854 matching lines @@
   HEAP->disallow_allocation_failure_ = old_state_;
 #endif
 }
 
 
 #ifdef DEBUG
 bool EnterAllocationScope(Isolate* isolate, bool allow_allocation) {
   bool active = !isolate->optimizing_compiler_thread()->IsOptimizerThread();
   bool last_state = isolate->heap()->IsAllocationAllowed();
   if (active) {
+    // TODO(yangguo): Make HandleDereferenceGuard avoid isolate mutation in the
+    // same way if running on the optimizer thread.
     isolate->heap()->set_allow_allocation(allow_allocation);
   }
   return last_state;
 }
 
 
 void ExitAllocationScope(Isolate* isolate, bool last_state) {
-  isolate->heap()->set_allow_allocation(last_state);
+  bool active = !isolate->optimizing_compiler_thread()->IsOptimizerThread();
+  if (active) {
+    isolate->heap()->set_allow_allocation(last_state);
+  }
 }
 
 
 AssertNoAllocation::AssertNoAllocation()
     : last_state_(EnterAllocationScope(ISOLATE, false)) {
 }
 
 AssertNoAllocation::~AssertNoAllocation() {
   ExitAllocationScope(ISOLATE, last_state_);
 }
@@ skipping 11 matching lines @@
 AssertNoAllocation::~AssertNoAllocation() { }
 DisableAssertNoAllocation::DisableAssertNoAllocation() { }
 DisableAssertNoAllocation::~DisableAssertNoAllocation() { }
 
 #endif
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_INL_H_