Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1479563002: Don't use SkRect::MakeLargest() for clip bounds in image filter tests. (Closed)

Created:
5 years ago by Stephen White
Modified:
5 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't use SkRect::MakeLargest() for clip bounds in image filter tests. Much of the Skia code dealing with clip bounds does not handle overflow, so if we start doing any math on these rects, the code will break. Use explicit reasonable values instead. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8444913d2c32ceca8a0f22c9dd7537c615c39af7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tests/ImageFilterTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Stephen White
Rob: PTAL. Thanks!
5 years ago (2015-11-25 18:07:17 UTC) #2
robertphillips
lgtm
5 years ago (2015-11-25 18:19:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479563002/1
5 years ago (2015-11-25 18:20:05 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 18:32:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8444913d2c32ceca8a0f22c9dd7537c615c39af7

Powered by Google App Engine
This is Rietveld 408576698