test/cctest/test-heap.cc - Issue 1479543002: [proxies] Implement [[Delete]].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1479543002: [proxies] Implement [[Delete]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix typo Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index 08097c33ae51cd43c99843b0942f21d874edca8f..dbfad91c3090691341580ec9e1bcaa68d77e7740 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -911,7 +911,7 @@ TEST(ObjectProperties) {

CHECK(Just(true) == JSReceiver::HasOwnProperty(obj, first));

// delete first

- JSReceiver::DeleteProperty(obj, first, SLOPPY).Check();

+ CHECK(Just(true) == JSReceiver::DeleteProperty(obj, first, SLOPPY));

CHECK(Just(false) == JSReceiver::HasOwnProperty(obj, first));

// add first and then second

@@ -921,9 +921,9 @@ TEST(ObjectProperties) {

CHECK(Just(true) == JSReceiver::HasOwnProperty(obj, second));

// delete first and then second

- JSReceiver::DeleteProperty(obj, first, SLOPPY).Check();

+ CHECK(Just(true) == JSReceiver::DeleteProperty(obj, first, SLOPPY));

CHECK(Just(true) == JSReceiver::HasOwnProperty(obj, second));

- JSReceiver::DeleteProperty(obj, second, SLOPPY).Check();

+ CHECK(Just(true) == JSReceiver::DeleteProperty(obj, second, SLOPPY));

CHECK(Just(false) == JSReceiver::HasOwnProperty(obj, first));

CHECK(Just(false) == JSReceiver::HasOwnProperty(obj, second));

@@ -934,9 +934,9 @@ TEST(ObjectProperties) {

CHECK(Just(true) == JSReceiver::HasOwnProperty(obj, second));

// delete second and then first

- JSReceiver::DeleteProperty(obj, second, SLOPPY).Check();

+ CHECK(Just(true) == JSReceiver::DeleteProperty(obj, second, SLOPPY));

CHECK(Just(true) == JSReceiver::HasOwnProperty(obj, first));

- JSReceiver::DeleteProperty(obj, first, SLOPPY).Check();

+ CHECK(Just(true) == JSReceiver::DeleteProperty(obj, first, SLOPPY));

CHECK(Just(false) == JSReceiver::HasOwnProperty(obj, first));

CHECK(Just(false) == JSReceiver::HasOwnProperty(obj, second));