Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-elements-kind.cc

Issue 1479543002: [proxies] Implement [[Delete]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix typo Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-scopes.cc ('k') | test/cctest/test-heap.cc » ('j') | test/mjsunit/harmony/proxies-delete-property.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-elements-kind.cc
diff --git a/test/cctest/test-elements-kind.cc b/test/cctest/test-elements-kind.cc
index 672c3074b69dfa3c51423892195a77b2e0b79468..b97847f3d45dba78d21bc7cf017adc36c3a1ef96 100644
--- a/test/cctest/test-elements-kind.cc
+++ b/test/cctest/test-elements-kind.cc
@@ -314,7 +314,7 @@ TEST(JSArrayAddingElementsGeneralizingiFastSmiElements) {
// `delete array[0]` does not alter length, but changes the elments_kind
name = MakeString("0");
- JSReceiver::DeletePropertyOrElement(array, name).Check();
+ CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
CHECK_NE(array->map(), *previous_map);
CHECK_EQ(array->map()->elements_kind(), FAST_HOLEY_SMI_ELEMENTS);
CHECK_EQ(1, Smi::cast(array->length())->value());
@@ -387,7 +387,7 @@ TEST(JSArrayAddingElementsGeneralizingFastElements) {
// `delete array[0]` does not alter length, but changes the elments_kind
name = MakeString("0");
- JSReceiver::DeletePropertyOrElement(array, name).Check();
+ CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
CHECK_NE(array->map(), *previous_map);
CHECK_EQ(array->map()->elements_kind(), FAST_HOLEY_ELEMENTS);
CHECK_EQ(1, Smi::cast(array->length())->value());
@@ -444,7 +444,7 @@ TEST(JSArrayAddingElementsGeneralizingiFastDoubleElements) {
// `delete array[0]` does not alter length, but changes the elments_kind
name = MakeString("0");
- JSReceiver::DeletePropertyOrElement(array, name).Check();
+ CHECK(JSReceiver::DeletePropertyOrElement(array, name).FromMaybe(false));
CHECK_NE(array->map(), *previous_map);
CHECK_EQ(array->map()->elements_kind(), FAST_HOLEY_DOUBLE_ELEMENTS);
CHECK_EQ(2, Smi::cast(array->length())->value());
« no previous file with comments | « src/runtime/runtime-scopes.cc ('k') | test/cctest/test-heap.cc » ('j') | test/mjsunit/harmony/proxies-delete-property.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698