Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147953009: Fallback to CDD/CJT if connector can't initialize XPS API. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Fallback to CDD/CJT if connector can't initialize XPS API. BUG=317027 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250018

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -31 lines) Patch
M chrome/common/cloud_print/cloud_print_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_helpers.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.cc View 1 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/print_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 2 3 9 chunks +33 lines, -24 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 10 months ago (2014-02-07 00:04:46 UTC) #1
Noam Samuel
lgtm https://codereview.chromium.org/147953009/diff/1/chrome/service/cloud_print/print_system_win.cc File chrome/service/cloud_print/print_system_win.cc (right): https://codereview.chromium.org/147953009/diff/1/chrome/service/cloud_print/print_system_win.cc#newcode80 chrome/service/cloud_print/print_system_win.cc:80: wchar_t* mutable_name = const_cast<wchar_t*>(printer_name.c_str()); Is it kosher to ...
6 years, 10 months ago (2014-02-07 19:47:52 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-09 11:31:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/147953009/270001
6 years, 10 months ago (2014-02-09 11:31:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-09 11:53:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=223972
6 years, 10 months ago (2014-02-09 11:53:10 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-09 12:03:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/147953009/570001
6 years, 10 months ago (2014-02-09 12:03:41 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-09 22:51:55 UTC) #9
Message was sent while issue was closed. 
Change committed as 250018

Powered by Google App Engine
This is Rietveld 408576698