Add support for custom elements to MDV

sdk/lib/html/dart2js/html_dart2js.dart

Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 107961528981c75dd7f9ad625c29bfcb507a9ebc..02aca2b95a8b98bcda69a7e2d557bd83a4ba929e 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7386,18 +7386,27 @@ abstract class Element extends Node implements ElementTraversal native "Element"
   void onCreated() {}
 
   // Hooks to support custom WebComponents.
+
+  @Creates('Null')  // Set from Dart code; does not instantiate a native type.
+  Element _xtag;
+
   /**
    * Experimental support for [web components][wc]. This field stores a
    * reference to the component implementation. It was inspired by Mozilla's
    * [x-tags][] project. Please note: in the future it may be possible to
    * `extend Element` from your class, in which case this field will be
-   * deprecated and will simply return this [Element] object.
+   * deprecated.
+   *
+   * If xtag has not been set, it will simply return `this` [Element].
    *
    * [wc]: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/explainer/index.html
    * [x-tags]: http://x-tags.org/
    */
-  @Creates('Null')  // Set from Dart code; does not instantiate a native type.
-  var xtag;
+  Element get xtag => _xtag != null ? _xtag : this;
+
+  void set xtag(Element value) {
+    _xtag = value;
+  }
 
   /**
    * Scrolls this element into view.
@@ -7621,7 +7630,7 @@ abstract class Element extends Node implements ElementTraversal native "Element"
       self._attributeBindings = new Map<String, StreamSubscription>();
     }
 
-    self.attributes.remove(name);
+    self.xtag.attributes.remove(name);
 
     var changed;
     if (name.endsWith('?')) {
@@ -7629,16 +7638,16 @@ abstract class Element extends Node implements ElementTraversal native "Element"
 
       changed = (value) {
         if (_templateBooleanConversion(value)) {
-          self.attributes[name] = '';
+          self.xtag.attributes[name] = '';
         } else {
-          self.attributes.remove(name);
+          self.xtag.attributes.remove(name);
         }
       };
     } else {
       changed = (value) {
         // TODO(jmesserly): escape value if needed to protect against XSS.
         // See https://github.com/toolkitchen/mdv/issues/58
-        self.attributes[name] = value == null ? '' : '$value';
+        self.xtag.attributes[name] = value == null ? '' : '$value';
       };
     }
 
@@ -26479,7 +26488,7 @@ void _parseAndBind(Node node, String name, String text, model,
     return newValue.toString();
   };
 
-  node.bind(name, replacementBinding, 'value');
+  _nodeOrCustom(node).bind(name, replacementBinding, 'value');
 }
 
 void _bindOrDelegate(node, name, model, String path,
@@ -26493,9 +26502,17 @@ void _bindOrDelegate(node, name, model, String path,
     }
   }
 
-  node.bind(name, model, path);
+  _nodeOrCustom(node).bind(name, model, path);
 }
 
+/**
+ * Gets the [node]'s custom [Element.xtag] if present, otherwise returns
+ * the node. This is used so nodes can override [Node.bind], [Node.unbind],
+ * and [Node.unbindAll] like

[Siggi Cherem (dart-lang), 2013/05/13 16:42:13]

like ... ?

[Jennifer Messerly, 2013/05/13 19:42:41]

hah, not sure what happened. Fixed :)

+ */
+// TODO(jmesserly): remove this when we can extend Element for real.
+_nodeOrCustom(node) => node is Element ? node.xtag : node;

[blois, 2013/05/13 17:45:13]

Can this have a return type?

Also, possibly make it a static method somewhere? Since this is in a ginormous
library it's nice to avoid library functions when possible- they tend to get
lost.

[Jennifer Messerly, 2013/05/13 19:42:41]

It cannot, unless the type is Object :). I had "Node" there but sometimes
"CustomBinding" is used. :(

One thing I'd like to fix (at some point) is to either not use CustomBinding
like that, or at least create an interface with bind/unbind/unbindAll.
All methods in this file are top-level, so I presume you mean convert the entire
file? :)

Although it technically violates rule #1 of the Dart style guide :), I'm
sympathetic that dart:html has special constraints. Here's a proposal: after
this CL lands I move all top-levels in TemplateBindings to be static methods on
some class ("_Bindings"?). Sound good?

[Jennifer Messerly, 2013/05/13 20:24:36]

follow up on static methods:
https://codereview.chromium.org/14634011/

+
 class _BindingToken {
   final String value;
   final bool isBinding;
@@ -26555,7 +26572,7 @@ void _addTemplateInstanceRecord(fragment, model) {
 }
 
 void _removeAllBindingsRecursively(Node node) {
-  node.unbindAll();
+  _nodeOrCustom(node).unbindAll();
   for (var c = node.$dom_firstChild; c != null; c = c.nextNode) {
     _removeAllBindingsRecursively(c);
   }