Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1479483002: X87: [turbofan] Add general support for sp-based frame access. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add general support for sp-based frame access. port 51669873694ed266ea06a2726f87138374eea1e7 (r32234) original commit message: Some highlights of this CL: * Refactor the mutable state out of Frame into FrameAccessState, which is maintained and updated during code generation to record whether sp- or fp-based frame access is currently active and how deep the stack on top of the frame is. * The operand resultion in linkage.cc now uses FrameAccessState to determine how to generate frame-accessing operands. * Update all platforms to accurately track additionally pushed stack slots (e.g. arguments for calls) in the FrameAccessState. * Add a flag, --turbo_sp_frame_access, which forces all frame access to be sp-based whenever possible. This will likely never be used in production, but for testing it's useful in verifying that the stack-tracking of each platform maintained in the FrameAccessState is correct. * Use sp-based frame access for gap resolving before tail calls. This will allow for slightly more efficient restoration of the frame pointer in the tail call in a later CL. * Remove most ad hoc groping into CallDescriptors to determine if a frame is needed, instead consistently use predicates like needs_frame(), IsCFunctionCall() and IsJSFunctionCall(). BUG= Committed: https://crrev.com/240571d768e4a92e444988b7b65f7f5934e8bdba Cr-Commit-Position: refs/heads/master@{#32253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 15 chunks +40 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years ago (2015-11-25 06:15:36 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 08:19:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479483002/1
5 years ago (2015-11-25 08:19:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 08:43:02 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 08:43:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/240571d768e4a92e444988b7b65f7f5934e8bdba
Cr-Commit-Position: refs/heads/master@{#32253}

Powered by Google App Engine
This is Rietveld 408576698