base/trace_event/trace_event_memory.cc - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_memory.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_memory.cc

diff --git a/base/trace_event/trace_event_memory.cc b/base/trace_event/trace_event_memory.cc

index 73c8536cac2a83a2145a88e93c35ec0a61d45490..187bf7469bff0fe26e6847a90873fb4f02536141 100644

--- a/base/trace_event/trace_event_memory.cc

+++ b/base/trace_event/trace_event_memory.cc

@@ -4,6 +4,8 @@

#include "base/trace_event/trace_event_memory.h"

+#include <utility>

#include "base/debug/leak_annotations.h"

#include "base/lazy_instance.h"

#include "base/location.h"

@@ -149,7 +151,7 @@ TraceMemoryController::TraceMemoryController(

HeapProfilerStartFunction heap_profiler_start_function,

HeapProfilerStopFunction heap_profiler_stop_function,

GetHeapProfileFunction get_heap_profile_function)

- : task_runner_(task_runner.Pass()),

+ : task_runner_(std::move(task_runner)),

heap_profiler_start_function_(heap_profiler_start_function),

heap_profiler_stop_function_(heap_profiler_stop_function),

get_heap_profile_function_(get_heap_profile_function),

« base/sequence_checker_unittest.cc ('K') | « base/trace_event/trace_event_argument_unittest.cc ('k') | base/trace_event/trace_log.cc » ('j') | no next file with comments »