base/prefs/pref_service_factory.cc - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_service_factory.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_service_factory.cc

diff --git a/base/prefs/pref_service_factory.cc b/base/prefs/pref_service_factory.cc

index 8caf073e7bb1de01ca27e85cd8fd91292e281d22..2380a86b5ace842d9920fbec450e302f3a3ca6b8 100644

--- a/base/prefs/pref_service_factory.cc

+++ b/base/prefs/pref_service_factory.cc

@@ -59,7 +59,7 @@ scoped_ptr<PrefService> PrefServiceFactory::Create(

pref_registry,

read_error_callback_,

async_));

- return pref_service.Pass();

+ return pref_service;

}

} // namespace base

« no previous file with comments | « base/prefs/pref_service.cc ('k') | base/prefs/pref_value_map.cc » ('j') | base/process/process_metrics.cc » ('J')