Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1479443002: Fixed an issue where tracing events got incorrectly enabled. (Closed)

Created:
5 years ago by oystein (OOO til 10th of July)
Modified:
5 years ago
Reviewers:
shatch, sh
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, Zhen Wang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed an issue where tracing events got incorrectly enabled. This specifically happened when the tracing config had excluded specific categories, and a multi-category trace event occured with one of its categories present in the excluded list. The code incorrectly assumed this meant the non-excluded categories were enabled, not accounting for disabled-by-default categories. R=simonhatch@chromium.org BUG=560485 Committed: https://crrev.com/a8a6d97c857fd1ce2b94bb710e9af7a24700907a Cr-Commit-Position: refs/heads/master@{#361667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M base/trace_event/trace_config.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
oystein (OOO til 10th of July)
ptal!
5 years ago (2015-11-24 22:33:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479443002/1
5 years ago (2015-11-24 22:37:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 01:55:34 UTC) #6
sh
lgtm
5 years ago (2015-11-25 15:44:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479443002/1
5 years ago (2015-11-25 15:44:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 15:50:05 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-25 15:51:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8a6d97c857fd1ce2b94bb710e9af7a24700907a
Cr-Commit-Position: refs/heads/master@{#361667}

Powered by Google App Engine
This is Rietveld 408576698