Make contenteditable="false" element as atomic node for selection motion

Source/core/editing/htmlediting.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 48 matching lines @@
 using namespace std;
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 // Atomic means that the node has no children, or has children which are ignored for the
 // purposes of editing.
 bool isAtomicNode(const Node *node)
 {
-    return node && (!node->hasChildNodes() || editingIgnoresContent(node));
+    if (!node)
+        return false;
+    if (!node->hasChildNodes() || editingIgnoresContent(node))
+        return true;
+    RenderObject* renderer = node->renderer();
+    if (!renderer)
+        return false;
+    if (renderer->isTable() || renderer->isTableRow())

[ojan, 2013/05/22 02:25:20]

I don't really understand this check. What's special about tables and table
rows?

[yosin_UTC9, 2013/05/22 07:54:12]

To move position into table cell, we should not make table element and table row
atomic even if they are uneditable.

Checking table and table row suppose:
 <table contenteditable=flase>
   <tr contenteditable=false>
     <td contenteditable=true>
       We wanna reach here!
     </td>
   </tr>
</table. 

[ojan, 2013/05/22 21:05:45]

How is this different from the following?

<div contentEditable=false>
    foo
    <div contentEditable=true>we want to reach here</div>
    bar
</div>

+        return false;
+    return renderer->style()->userModify() == READ_ONLY && lowestEditableAncestor(node);
 }
 
 // Compare two positions, taking into account the possibility that one or both
 // could be inside a shadow tree. Only works for non-null values.
 int comparePositions(const Position& a, const Position& b)
 {
     TreeScope* commonScope = commonTreeScope(a.containerNode(), b.containerNode());
 
     ASSERT(commonScope);
     if (!commonScope)
@@ skipping 41 matching lines @@
         if (node->rendererIsEditable(editableType))
             highestRoot = node;
         if (node->hasTagName(bodyTag))
             break;
         node = node->parentNode();
     }
     
     return highestRoot;
 }
 
-Node* lowestEditableAncestor(Node* node)
+Node* lowestEditableAncestor(const Node* node)
 {
     if (!node)
         return 0;
     
     Node* lowestRoot = 0;
     while (node) {
         if (node->rendererIsEditable())
             return node->rootEditableElement();
         if (node->hasTagName(bodyTag))
             break;
@@ skipping 1059 matching lines @@
     // if the selection starts just before a paragraph break, skip over it
     if (isEndOfParagraph(visiblePosition))
         return visiblePosition.next().deepEquivalent().downstream();
 
     // otherwise, make sure to be at the start of the first selected node,
     // instead of possibly at the end of the last node before the selection
     return visiblePosition.deepEquivalent().downstream();
 }
 
 } // namespace WebCore