Issue 14794004: Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target (reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14794004: Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target (reland) (Closed)

Created:
7 years, 7 months ago by scottmg

Modified:
7 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target (reland) Currently contains chrome_browser_dll target. Removes some paths from browser->webcore via content that are there due to single process mode, and removes dependency of content on content_renderer. Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg Reland of https://chromiumcodereview.appspot.com/14682014 TBR=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198928

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -86 lines)			Patch
M	build/common.gypi	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/app/chrome_main_delegate.cc	View		3 chunks	+24 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		3 chunks	+13 lines, -3 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1	5 chunks	+138 lines, -70 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/test/gpu/test_support_gpu.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/app/content_main_runner.cc	View		4 chunks	+20 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/content.gyp	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/public/app/content_main_delegate.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

scottmg

7 years, 7 months ago (2013-05-08 17:51:11 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r198928 (presubmit successful).