Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147933002: Remove the media attribute from the resource selection algorithm (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove the media attribute from the resource selection algorithm Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5sWUMC_d8Tg/ZZ0Z7rfeCqUJ The HTMLSourceElement.media IDL attribute is left dangling, but a UseCounter will be added for it in a separate commit, with the intention to remove it once we have the data to support it. BUG=338197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M LayoutTests/media/video-source-error.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/media/video-source-error-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/media/video-source-media.html View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
philipj_slow
Adam, can you take this one? Aaron is OOO.
6 years, 10 months ago (2014-01-27 02:04:27 UTC) #1
adamk
lgtm based on the lgtms on blink-dev.
6 years, 10 months ago (2014-01-28 23:49:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/147933002/1
6 years, 10 months ago (2014-01-29 02:03:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9638
6 years, 10 months ago (2014-01-29 07:35:07 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 07:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/147933002/1
6 years, 10 months ago (2014-01-29 09:43:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=9705
6 years, 10 months ago (2014-01-29 14:36:06 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 14:36:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/147933002/1
6 years, 10 months ago (2014-01-29 15:11:45 UTC) #9
commit-bot: I haz the power
Change committed as 166034
6 years, 10 months ago (2014-01-29 16:49:03 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 16:49:30 UTC) #11
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698