Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1479293002: Rename %_IsSpecObject to %_IsJSReceiver. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename %_IsSpecObject to %_IsJSReceiver. This depends on issue 1476403004. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/9334308a12acb383942e26428aedcc74f6be04a1 Cr-Commit-Position: refs/heads/master@{#32401}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/js/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/constant-fold-control-instructions.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-995.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
5 years ago (2015-11-27 17:13:02 UTC) #1
Benedikt Meurer
lgtm
5 years ago (2015-11-30 09:19:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479293002/20001
5 years ago (2015-11-30 11:35:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 11:56:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 11:56:50 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9334308a12acb383942e26428aedcc74f6be04a1
Cr-Commit-Position: refs/heads/master@{#32401}

Powered by Google App Engine
This is Rietveld 408576698